lkml.org 
[lkml]   [2008]   [Feb]   [21]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: Merging of completely unreviewed drivers
    On Fri, Feb 22, 2008 at 01:33:03AM +0300, Alexey Dobriyan wrote:
    > On Thu, Feb 21, 2008 at 01:14:55PM -0800, Linus Torvalds wrote:
    > > Quite frankly, I've several times been *this* close (holds up fingers so
    > > you can't even see between them) to just remove checkpatch entirely.
    >
    > Agrh! What stopped you?!
    >
    > > I'm personally of the opinion that a lot of checkpatch "fixes" are
    > > anything but. That mainly concerns fixing overlong lines (where the
    > > "fixed" version is usually worse than the original), but it's been true
    > > for some other warnings too.
    >
    > Speaking of driver, could authors please comment all those barrier()
    > calls and remove trailing "return;" at the end of void functions.

    Why don't you make a patch to checkpatch.pl for those types of things?
    :)



    \
     
     \ /
      Last update: 2008-02-21 23:47    [W:0.021 / U:30.404 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site