Messages in this thread | | | Date | Thu, 21 Feb 2008 21:37:48 +0100 | From | Ingo Molnar <> | Subject | Re: [PATCH] X86: don't print a warning when MTRR are blank and running in KVM |
| |
* Joerg Roedel <joerg.roedel@amd.com> wrote:
> - if (!highest_pfn) { > + if (!highest_pfn && !kvm_para_available()) { > printk(KERN_WARNING "WARNING: strange, CPU MTRRs all blank?\n"); > WARN_ON(1); > - return 0; > } > > + if (!highest_pfn) > + return 0;
hm, why not have a single test for !highest_pfn:
if (!highest_pfn) { if (!kvm_para_available()) { printk(KERN_WARNING "WARNING: strange, CPU MTRRs all blank?\n"); WARN_ON(1); } return 0; }
? But yeah, your patch looks good otherwise.
I'm not sure how we could detect pure Qemu instances - perhaps it should define some special MSR or something?
Ingo
| |