Messages in this thread | | | Date | Wed, 20 Feb 2008 17:30:43 +0100 (CET) | From | Jan Engelhardt <> | Subject | Re: [RFC PATCH 3/8] [NET]: uninline dev_alloc_skb, de-bloats a lot |
| |
On Feb 20 2008 17:27, Patrick McHardy wrote: >> Striking. How can this even happen? A callsite which calls >> >> dev_alloc_skb(n) >> >> is just equivalent to >> >> __dev_alloc_skb(n, GFP_ATOMIC); >> >> which means there's like 4 (or 8 if it's long) bytes more on the >> stack. For a worst case, count in another 8 bytes for push and pop or mov on >> the stack. But that still does not add up to 23 kb. > > __dev_alloc_skb() is also an inline function which performs > some extra work. Which raises the question - if dev_alloc_skb() > is uninlined, shouldn't __dev_alloc_skb() be uninline as well? > I'd like to see the results when {__dev_alloc_skb is externed and dev_alloc_skb remains inlined}.
| |