Messages in this thread |  | | | Date | Tue, 19 Feb 2008 21:47:58 -0800 | | From | Greg KH <> | | Subject | Re: pci/pcie/aer/aerdrv_acpi.c: inconsequent NULL checking | |
On Tue, Feb 19, 2008 at 09:29:02PM +0200, Adrian Bunk wrote:
> The Coverity checker spotted the following inconsequent NULL checking
> introduced by commit 3c75e23784e6ed5f4841de43d0750fd9b37bafcb:
>
> <-- snip -->
>
> ...
> int aer_osc_setup(struct pcie_device *pciedev)
> {
> ... vvvvvvvvv
> while (pdev->bus && pdev->bus->self)
> pdev = pdev->bus->self;
That could probably change to just pdev->bus->self, as a bus should
always be there for a pdev, so I don't see this as a problem.
thanks,
greg k-h
|  |