lkml.org 
[lkml]   [2008]   [Feb]   [2]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH 3 of 5] x86/pgtable.h: demacro ptep_set_access_flags
    Ingo Molnar wrote:
    > another thing: these inlines are a bit fat and they are used in more
    > than one place. Please move them into pgtable.c. The rule of thumb is:
    > if an inline is more than 2 lines big, it is a likely candidate for
    > uninlining. (and even many 2-liners, and even some 1-liners are
    > candidates) Especially under paravirt the MMU inlines grow these update
    > notifiers so they become even fatter.
    >

    I agree, but I wanted to keep it semantically equivalent to the
    original. I'll add a move to out of line patch.

    > having functions instead of inlines also simplifies the type
    > dependencies by quite a degree.
    >

    Indeed, the floating asm/tlbflush.h is a bit of a wart.

    J


    \
     
     \ /
      Last update: 2008-02-02 11:23    [W:0.036 / U:31.208 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site