lkml.org 
[lkml]   [2008]   [Feb]   [2]   [last100]   RSS Feed
Views: [more markup]  [less markup]  [headers]  [forward] 
 
Messages in this thread
/
DateSat, 2 Feb 2008 10:27:50 +0100
FromIngo Molnar <>
SubjectRe: [PATCH 3 of 5] x86/pgtable.h: demacro ptep_set_access_flags
i've applied this series too. It's pretty straightforward changes, 
mostly at the right granularity level.

a few style nits though (i fixed them up, so no need to resend):

> +static inline int ptep_set_access_flags(struct vm_area_struct *vma,
> +					unsigned long address, pte_t *ptep,
> +					pte_t entry, int dirty)
> +{
> +	int changed = !pte_same(*ptep, entry);
> +	if (changed && dirty) {
> +		*ptep = entry;

we put a newline between variable definitions and the first code 
statement. That makes it a tiny bit easier to see the structure of the 
code.

	Ingo


\
 
 \ /
  Last update: 2008-02-02 09:31    [from the cache]
©2003-2008