lkml.org 
[lkml]   [2008]   [Feb]   [2]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [patch] pci: pci_enable_device_bars() fix (was: [GIT PATCH] PCI patches for 2.6.24)
On Sat, Feb 02, 2008 at 12:13:22PM +0100, Ingo Molnar wrote:
>
> * Greg KH <gregkh@suse.de> wrote:
>
> > PCI: Remove users of pci_enable_device_bars()
> > PCI: Remove pci_enable_device_bars()
>
> simple allyesconfig testing found a build failure due to last night's
> PCI merge, on 32-bit x86:
>
> drivers/scsi/lpfc/lpfc_init.c: In function 'lpfc_pci_probe_one':
> drivers/scsi/lpfc/lpfc_init.c:1897: error: implicit declaration of function 'pci_enable_device_bars'
>
> fix attached.
>
> ( This call has been introduced upstream 3 weeks ago by commit
> 8a4df120b07, but the PCI tree has apparently not been fully re-tested
> with Linus-latest since that point. )

Wait, my testing caught this. I made the change to the patch myself,
adding the needed conversion to my tree, it's here, on my disk!

Oh crap, I never checked it in.

/me goes off to sulk in shame.

Very sorry about this, totally my fault, I knew this needed to be fixed,
fixed it, but it didn't propogate to the tree to send to Linus.

I suck. I need a vacation and an empty inbox.

I'll be sending fixup patches for this and other merge messes in a few
hours, once the coffee has kicked in...

greg k-h


\
 
 \ /
  Last update: 2008-02-02 19:49    [W:0.216 / U:0.184 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site