lkml.org 
[lkml]   [2008]   [Feb]   [18]   [last100]   RSS Feed
Views: [more markup]  [less markup]  [headers]  [forward] 
 
Messages in this thread
/
SubjectRE: [PATCH 5/6] Add OF-tree support to RapidIO controller driver.
DateMon, 18 Feb 2008 15:24:30 +0800
From"Zhang Wei" <>

> -----Original Message-----
> From: Kumar Gala [mailto:galak@kernel.crashing.org] 
> 
> 
> On Feb 4, 2008, at 11:44 PM, Stephen Rothwell wrote:
> 
> >>
> >> +	aw = *(u32 *)of_get_property(dev->node, "#address-cells", NULL);
> >> +	sw = *(u32 *)of_get_property(dev->node, "#size-cells", NULL);
> >
> > What happens if either of these properties is missing?
> 
> Should we add __must_check to of_get_property?
> 

You are right, I'll add the checking here.

Thanks!
Wei.


\
 
 \ /
  Last update: 2008-02-18 08:27    [from the cache]
©2003-2008