lkml.org 
[lkml]   [2008]   [Feb]   [18]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH 2/2] [RESENDING] fs/ocfs2: get rid of unnecessary initialization
    On Mon, Feb 11, 2008 at 06:08:31PM +0900, Joonwoo Park wrote:
    > default_groups was allocated with kcalloc, so initialize to NULL
    > is unnecessary.

    NACK - this isn't a performance critical section of code and that line makes
    the array termination obvious, so I'm inclined to leave it as is.

    Thanks,
    --Mark

    --
    Mark Fasheh
    Principal Software Developer, Oracle
    mark.fasheh@oracle.com


    \
     
     \ /
      Last update: 2008-02-18 20:35    [W:0.035 / U:30.288 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site