lkml.org 
[lkml]   [2008]   [Feb]   [18]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 2/2] [RESENDING] fs/ocfs2: get rid of unnecessary initialization
On Mon, Feb 11, 2008 at 06:08:31PM +0900, Joonwoo Park wrote:
> default_groups was allocated with kcalloc, so initialize to NULL
> is unnecessary.

NACK - this isn't a performance critical section of code and that line makes
the array termination obvious, so I'm inclined to leave it as is.

Thanks,
--Mark

--
Mark Fasheh
Principal Software Developer, Oracle
mark.fasheh@oracle.com


\
 
 \ /
  Last update: 2008-02-18 20:35    [from the cache]
©2003-2011 Jasper Spaans. Advertise on this site