lkml.org 
[lkml]   [2008]   [Feb]   [17]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] mm: setup_usemap() must be __meminit
On Sun, 17 Feb 2008, Sam Ravnborg wrote:
> On Sun, Feb 17, 2008 at 01:31:14PM +0100, Geert Uytterhoeven wrote:
> > On Sun, 17 Feb 2008, Geert Uytterhoeven wrote:
> > > On m68k (CONFIG_SPARSEMEM is not set), I get:
> > >
> > > WARNING: vmlinux.o(.meminit.text+0x36c): Section mismatch in reference from the function free_area_init_core() to the function .init.text:setup_usemap()
> > > The function __meminit free_area_init_core() references
> > > a function __init setup_usemap().
> > > If free_area_init_core is only used by setup_usemap then
> > > annotate free_area_init_core with a matching annotation.
> > >
> > > If CONFIG_SPARSEMEM is set, the problem is not noticed because setup_usemap()
> > > is always inlined.
> > >
> > > Properly annotating setup_usemap() and usemap_size() fixes it.
> >
> > Woops, hit the send button too soon.
> >
> > setup_usemap() calls alloc_bootmem_node(), causing a whole new
> > avalanche of warnings to be fixed up :-(
>
> Something you like me to help with?

Yes, that would be nice.

> I would need a config where the mismatch triggers for one
> of the more popular architectures (as in where I have a toolchain).

That was with plain m68k defconfig.

> I could not reproduce it with x86 64bit - not even with -fno-inline-functions

If it helps, my cross-compiler is gcc version 4.1.2 20061115 (prerelease)
(Debian 4.1.1-21).

Gr{oetje,eeting}s,

Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds


\
 
 \ /
  Last update: 2008-02-17 21:43    [W:0.057 / U:0.204 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site