lkml.org 
[lkml]   [2008]   [Feb]   [16]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: kernel-doc : possible fix for non-fatal perl errors when parsing some function pointers
From
Date

On Fri, 2008-02-15 at 14:46 -0800, Randy Dunlap wrote:
> On Fri, 15 Feb 2008 17:42:24 +0000 Richard Kennedy wrote:
>
> >
> > On Fri, 2008-02-15 at 09:21 -0800, Randy Dunlap wrote:
> > > On Fri, 15 Feb 2008 17:13:12 +0000 Richard Kennedy wrote:
> > >
> > > > When running "make htmldocs" I'm seeing some non-fatal perl errors
> > > > caused by trying to parse the callback function definitions in
> > > > blk-core.c.
> > > >
> > > >
> > >
> > > Hi Richard,
> > > Thanks for the patch. I was planning to look into this problem
> > > this weekend.
> > >
> > > I think that changing scripts/kernel-doc to accept the current
> > > kernel source tree usage is the right thing to do, even if the
> > > block/blk code is a bit different. I'll test it a bit and then
> > > push it.
> > >
> > > I appreciate the patch.
> > >
> > No problem.
> >
> > I have given the patch some testing, and the output xml is the same
> > except for the blk_end_request_callback entry.
> >
> > But I wonder if it should change to this :-
> >
> > > - $type =~ s/([^\(]+\(\*)$param/$1/;
> > > + $type =~ s/([^\(]+\(\*?)\s*$param/$1/;
> >
> > just in case there is some stray whitespace in there.
>
> That should be OK, so I changed that line.
>
> Can I get a Signed-off-by: from you, please?
>
> Thanks,
> ---
Signed-off-by: Richard Kennedy <richard@rsk.demon.co.uk>



\
 
 \ /
  Last update: 2008-02-16 12:05    [W:0.045 / U:0.444 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site