Messages in this thread | | | Date | Sat, 16 Feb 2008 20:47:08 -0800 | From | Randy Dunlap <> | Subject | Re: [PATCH v2] Re: 2.6.25-rc2-mm1 (wakeup) |
| |
H. Peter Anvin wrote: > Randy Dunlap wrote: >> On Sat, 16 Feb 2008 19:58:06 -0800 H. Peter Anvin wrote: >> >>> Randy Dunlap wrote: >>>> Yes, adding -m32 to the X86_32 config ccflags (as is done for the >>>> X86_64 case) makes it build for me. (like patch below) >>>> >>> It's wrong, though, because you can't assume a 32-bit compiler knows >>> about -m32. >>> >>> You need $(call cc-option,-m32). >> >> -cflags-$(CONFIG_X86_32) := >> +cflags-$(CONFIG_X86_32) := $(call cc-option, -m32) >> cflags-$(CONFIG_X86_64) := -m32 > > I think this works for both; that's what we do for arch/x86/boot.
OK, that makes sense. I think I'll let Rafael complete it.
-- ~Randy
| |