lkml.org 
[lkml]   [2008]   [Feb]   [16]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH v2] Re: 2.6.25-rc2-mm1 (wakeup)
    H. Peter Anvin wrote:
    > Randy Dunlap wrote:
    >> On Sat, 16 Feb 2008 19:58:06 -0800 H. Peter Anvin wrote:
    >>
    >>> Randy Dunlap wrote:
    >>>> Yes, adding -m32 to the X86_32 config ccflags (as is done for the
    >>>> X86_64 case) makes it build for me. (like patch below)
    >>>>
    >>> It's wrong, though, because you can't assume a 32-bit compiler knows
    >>> about -m32.
    >>>
    >>> You need $(call cc-option,-m32).
    >>
    >> -cflags-$(CONFIG_X86_32) :=
    >> +cflags-$(CONFIG_X86_32) := $(call cc-option, -m32)
    >> cflags-$(CONFIG_X86_64) := -m32
    >
    > I think this works for both; that's what we do for arch/x86/boot.

    OK, that makes sense. I think I'll let Rafael complete it.

    --
    ~Randy


    \
     
     \ /
      Last update: 2008-02-17 05:49    [W:6.380 / U:0.028 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site