[lkml]   [2008]   [Feb]   [16]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
    SubjectRe: [PATCHSET] printk: implement printk_header() and merging printk, take #3
    Tejun Heo wrote:
    > Andrew Morton wrote:
    >>> So, I guess it's NACK w/o suggested alternatives, right?
    >> I wouldn't nack without good reasons, and I have none here. I don't have
    >> very strong opinions either way.
    > I was just wondering whether I should just go with snprintf dancing in
    > eh_link_report, which does make sense if not many need merging printk.

    Any chance you could poke through snprintf() and look for the off-by-one bug
    on the return result? (I think it happens when "n" is exceeded).


     \ /
      Last update: 2008-02-16 16:25    [W:0.019 / U:76.832 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site