lkml.org 
[lkml]   [2008]   [Feb]   [15]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [patch] move wakeup code to .c
    Hi!

    > scripts/checkpatch.pl
    > ERROR: do not initialise externals to 0 or NULL
    > #113: FILE: arch/x86/boot/video-mode.c:29:
    > +int do_restore = 0; /* Screen contents changed during mode flip */

    We were doing file move with minimal changes.

    > ERROR: need a space before the open parenthesis '('
    > #710: FILE: arch/x86/kernel/acpi/realmode/wakemain.c:70:
    > + while(1);

    Bogus warning.

    I'll fix al but this one, but could we do it as a followup patch? I'm
    currently at holidays, moving .S code into .c is rather
    good/important, and it should get testing ASAP.
    Pavel
    --
    (english) http://www.livejournal.com/~pavelmachek
    (cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html


    \
     
     \ /
      Last update: 2008-02-15 10:59    [W:0.019 / U:33.556 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site