lkml.org 
[lkml]   [2008]   [Feb]   [15]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH 2/3] WDEV, ath5k, don't return int from bool function
    On 02/15/2008 11:08 PM, Luis R. Rodriguez wrote:
    > On Fri, Feb 15, 2008 at 3:58 PM, Jiri Slaby <jirislaby@gmail.com> wrote:
    >
    >> -static bool
    >> +static int
    >> ath5k_hw_setup_xr_tx_desc(struct ath5k_hw *ah, struct ath5k_desc *desc,
    >> unsigned int tx_rate1, u_int tx_tries1, u_int tx_rate2, u_int tx_tries2,
    >> unsigned int tx_rate3, u_int tx_tries3)
    >> @@ -3773,10 +3773,10 @@ ath5k_hw_setup_xr_tx_desc(struct ath5k_hw *ah, struct ath5k_desc *desc,
    >>
    >> #undef _XTX_TRIES
    >>
    >> - return true;
    >> + return 1;
    >> }
    >>
    >> - return false;
    >> + return 0;
    >> }
    >
    > Shouldn't we then treat 0 as OK?

    Sorry, I don't understand you. There is return -EINVAL in the function above
    this too and we need to cope with another two states but the error: it is
    supported/it isn't. You mean to consider 0 as supported, -ENODEV/-EOPNOTSUPP as
    unsupported and the rest as error?


    \
     
     \ /
      Last update: 2008-02-15 23:57    [W:0.020 / U:60.304 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site