lkml.org 
[lkml]   [2008]   [Feb]   [14]   [last100]   RSS Feed
Views: [more markup]  [less markup]  [headers]  [forward] 
 
Messages in this thread
/
DateThu, 14 Feb 2008 08:43:27 +0100
FromSam Ravnborg <>
SubjectRe: vmsplice exploits, stack protector and Makefiles
> --- linux-2.6.24.2/arch/x86/kernel/Makefile_64	2008-01-24 23:58:37.000000000 
> +0100
> +++ linux-2.6.24.2-pax/arch/x86/kernel/Makefile_64	2008-02-13 
> 11:36:14.000000000 +0100
> @@ -42,4 +42,6 @@ obj-$(CONFIG_PCI)		+= early-quirks.o
>  obj-y				+= topology.o
>  obj-y				+= pcspeaker.o
> 
> -CFLAGS_vsyscall_64.o		:= $(PROFILING) -g0
> +CFLAGS_vsyscall_64.o		:= $(PROFILING) -g0 -fno-stack-protector
> +CFLAGS_hpet.o			:= -fno-stack-protector
> +CFLAGS_tsc_64.o			:= -fno-stack-protector

We should use:
nostackp := $(call cc-option, -fno-stack-protector)
+CFLAGS_vsyscall_64.o		:= $(PROFILING) -g0 $(nostackp)
+CFLAGS_hpet.o			:= $(nostackp)
+CFLAGS_tsc_64.o		:= $(nostackp)

(or somthing similar)

because we cannot rely on that all gcc versions has support
for -fno-stack-protector

	Sam


\
 
 \ /
  Last update: 2008-02-14 08:47    [from the cache]
©2003-2008