Messages in this thread | | | Subject | Re: [PATCH] gdth: convert to PCI hotplug API | From | James Bottomley <> | Date | Thu, 14 Feb 2008 15:33:42 -0600 |
| |
On Tue, 2008-02-12 at 18:49 -0500, Jeff Garzik wrote: > Signed-off-by: Jeff Garzik <jgarzik@redhat.com>
Nice work, thanks. This is PCI only I take it. ISA and EISA look like they'll be a tad more troublesome, so PCI only is fine.
> --- > drivers/scsi/gdth.c | 143 +++++++++++++++++++++++++++++++--------------------- > 1 file changed, 86 insertions(+), 57 deletions(-) > > 06196f50915da97bb897495863f9f084d785c1e4 > diff --git a/drivers/scsi/gdth.c b/drivers/scsi/gdth.c > index c825239..1b53e92 100644 > --- a/drivers/scsi/gdth.c > +++ b/drivers/scsi/gdth.c > @@ -595,85 +595,107 @@ static int __init gdth_search_isa(ulong32 bios_adr) > #endif /* CONFIG_ISA */ > > #ifdef CONFIG_PCI > -static void gdth_search_dev(gdth_pci_str *pcistr, ushort *cnt, > - ushort vendor, ushort dev); > +static gdth_pci_str gdth_pcistr[MAXHA]; > +static int gdth_pci_cnt; > +static bool gdth_pci_registered;
Could we get rid of these static arrays and MAXHA entirely? It should be possible just to bung the parameters in pci_str into gdth_ha_str and dump the arrays.
Thanks,
James
| |