Messages in this thread | | | Date | Thu, 14 Feb 2008 08:37:17 -0500 | From | Mathieu Desnoyers <> | Subject | Re: [PATCH] spufs support multiple probes markers |
| |
* Christoph Hellwig (hch@infradead.org) wrote: > On Tue, Feb 12, 2008 at 06:56:50PM -0500, Mathieu Desnoyers wrote: > > Update spufs to the new linux kernel markers API, which supports connecting > > more than one probe to a single marker. > > Compiles and works for me. But saying I like the odd API would be lying. >
Are there any concerns of yours that I should address then ? The changes I made to the probe function prototype appeared to be technically required and caused by variadic argument limitations when it comes to support multiple probes.
I think that the marker arm/disarm removal gets rid of an unnecessary redundancy.
Mathieu
-- Mathieu Desnoyers Computer Engineering Ph.D. Student, Ecole Polytechnique de Montreal OpenPGP key fingerprint: 8CD5 52C3 8E3C 4140 715F BA06 3F25 A8FE 3BAE 9A68
| |