Messages in this thread | | | Date | Wed, 13 Feb 2008 21:34:50 +0100 | From | Sam Ravnborg <> | Subject | Re: KVM: Export include/linux/kvm.h only if $ARCH actually supports KVM |
| |
On Wed, Feb 13, 2008 at 09:43:49AM +0200, Avi Kivity wrote: > Olaf Hering wrote: > >>Currently, make headers_check barfs due to <asm/kvm.h>, which > >><linux/kvm.h> > >>includes, not existing. Rather than add a zillion <asm/kvm.h>s, export > >>kvm.h > >>only if the arch actually supports it. > >> > > > >This makes headers_install_all unreliable. > >linux/kvm.h will not be exported, depending on what system the libc > >headers will be generated. > > I see. Any suggestions besides adding lots of asm-*/kvm.h?
Do not include asm/kvm.h from linux/kvm.h. And in the few places where it is needed explicit include asm/kvm.h before linux/kvm.h.
Alternatively inlcude asm/kvm.h inside #ifdef KERNEL" so only userspace has to do explicit include of asm before linux variant.
Sam
| |