lkml.org 
[lkml]   [2008]   [Feb]   [13]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH] x86: include prototype for no_broadcast in mach-default/setup.c
From
Date
On Wed, 2008-02-13 at 11:42 +0100, Ingo Molnar wrote:
> * Harvey Harrison <harvey.harrison@gmail.com> wrote:
>
> > Fixes sparse warning:
> > arch/x86/mach-default/setup.c:19:5: warning: symbol 'no_broadcast' was not declared. Should it be static?
>
> hm, this patch causes a build failure:
>
> In file included from arch/x86/mach-default/setup.c:13:
> include/asm/mach-default/mach_ipi.h: In function '__local_send_IPI_allbutself':
> include/asm/mach-default/mach_ipi.h:25: error: 'APIC_DEST_ALLBUT' undeclared (first use in this function)
> include/asm/mach-default/mach_ipi.h:25: error: (Each undeclared identifier is reported only once
> include/asm/mach-default/mach_ipi.h:25: error: for each function it appears in.)include/asm/mach-default/mach_ipi.h: In function '__local_send_IPI_all':
> include/asm/mach-default/mach_ipi.h:33: error: 'APIC_DEST_ALLINC' undeclared (first use in this function)
>
> config attached. The include file dependencies in this area are a bit of
> a mess - perhaps they need some cleanups?

OK, I'm building all(yes|mod)configs and didn't see this. Agreed about
the file dependencies here, I'll take a look. If you have any notes
lying around, would appreciate the head-start.


Harvey




\
 
 \ /
  Last update: 2008-02-13 18:37    [W:0.089 / U:0.340 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site