lkml.org 
[lkml]   [2008]   [Feb]   [13]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] hwmon: (adm1026) Properly terminate sysfs groups (Was: panic about sysfs with adm1026)
Hi Jean et. al.:

* Jean Delvare <khali@linux-fr.org> [2008-02-10 19:01:15 +0100]:
> The missing NULL at the end of two sysfs file groups causes a kernel
> crash when calling sysfs_create_group().
>
> Signed-off-by: Jean Delvare <khali@linux-fr.org>
> ---
> drivers/hwmon/adm1026.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> --- linux-2.6.25-rc0.orig/drivers/hwmon/adm1026.c 2008-02-10 11:21:54.000000000 +0100
> +++ linux-2.6.25-rc0/drivers/hwmon/adm1026.c 2008-02-10 18:51:00.000000000 +0100
> @@ -1624,6 +1624,7 @@ static struct attribute *adm1026_attribu
> &dev_attr_temp3_crit_enable.attr,
> &dev_attr_temp3_auto_point1_pwm.attr,
> &dev_attr_temp3_auto_point2_pwm.attr,
> + NULL
> };
>
> static const struct attribute_group adm1026_group_temp3 = {
> @@ -1639,6 +1640,7 @@ static struct attribute *adm1026_attribu
> &sensor_dev_attr_in9_max.dev_attr.attr,
> &sensor_dev_attr_in9_min.dev_attr.attr,
> &sensor_dev_attr_in9_alarm.dev_attr.attr,
> + NULL
> };
>
> static const struct attribute_group adm1026_group_in8_9 = {

Applied to hwmon-2.6.git/testing, thanks.

--
Mark M. Hoffman
mhoffman@lightlink.com



\
 
 \ /
  Last update: 2008-02-13 14:23    [W:0.309 / U:0.036 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site