Messages in this thread | | | From | "Diego Guella" <> | Subject | Re: [ofa-general] [PATCH 2.6.25] RDMA/cxgb3: Fail loopbackconnections. | Date | Wed, 13 Feb 2008 10:18:53 +0100 |
| |
One question below
----- Original Message ----- From: "Roland Dreier" <rdreier@cisco.com> To: "Steve Wise" <swise@opengridcomputing.com> Cc: <netdev@vger.kernel.org>; <linux-kernel@vger.kernel.org>; <general@lists.openfabrics.org> Sent: Wednesday, February 13, 2008 1:26 AM Subject: Re: [ofa-general] [PATCH 2.6.25] RDMA/cxgb3: Fail loopbackconnections.
> applied, although: > > > +static void is_loopback_dst(struct iw_cm_id *cm_id) > > +{ > > + struct net_device *dev; > > + > > + dev = ip_dev_find(&init_net, cm_id->remote_addr.sin_addr.s_addr); > > + if (!dev) > > + return 0;
how can a static void function return 0? %)
> > + dev_put(dev); > > + return 1;
same here
| |