lkml.org 
[lkml]   [2008]   [Feb]   [12]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [patch 1/4] mempolicy: convert MPOL constants to enum
    Christoph wrote:
    > Good. And remove the enum.
    >
    > It would be better to add some sort of flags field?

    On the other hand, despite my brilliant (hah!) endorsement
    of bit field flags in my reply a few minutes ago, I'd settle
    for (1) removing the enum, and (2) using a flags field and
    more defines for the new stuff. I will grant that Christoph
    is correct that that form is more common in the kernel, and
    there is something to be said for doing things in the most
    common manner.

    --
    I won't rest till it's the best ...
    Programmer, Linux Scalability
    Paul Jackson <pj@sgi.com> 1.940.382.4214


    \
     
     \ /
      Last update: 2008-02-13 02:35    [W:0.019 / U:0.424 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site