Messages in this thread Patch in this message | | | Date | Tue, 12 Feb 2008 16:50:43 -0800 | From | Stephen Hemminger <> | Subject | [PATCH 1/4] rcu_assign_pointer: null check fix |
| |
Goofed on last change, should avoid barrier only on rcu_assign_pointer(p, NULL)
Signed-off-by: Stephen Hemminger <shemminger@vyatta.com> --- include/linux/rcupdate.h | 13 +++++++------ 1 files changed, 7 insertions(+), 6 deletions(-)
--- a/include/linux/rcupdate.h 2008-02-12 14:46:49.000000000 -0800 +++ b/include/linux/rcupdate.h 2008-02-12 14:56:17.000000000 -0800 @@ -178,7 +178,7 @@ struct rcu_head { #define rcu_assign_pointer(p, v) \ ({ \ - if (!(__builtin_constant_p(v) && v)) \ + if (!__builtin_constant_p(v) || v) \ smp_wmb(); \ (p) = (v); \ }) -- Stephen Hemminger <shemminger@vyatta.com>
| |