lkml.org 
[lkml]   [2008]   [Feb]   [12]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [RFC v3 5/7] dmaengine: Make DMA Engine menu visible for AVR32 users
On Feb 12, 2008 3:13 PM, Haavard Skinnemoen <hskinnemoen@atmel.com> wrote:
> On Tue, 12 Feb 2008 14:43:30 -0600
> Olof Johansson <olof@lixom.net> wrote:
>
> > > - depends on (PCI && X86) || ARCH_IOP32X || ARCH_IOP33X || ARCH_IOP13XX
> > > + depends on (PCI && X86) || ARCH_IOP32X || ARCH_IOP33X || ARCH_IOP13XX || AVR32
> >
> > This is a slippery slope. Things should be the other way around instead,
> > create a HAVE_DMA_DEVICE, select it in the relevant platform code and
> > make DMADEVICES depend on that.
>
> Agree. I'll cook up a patch tomorrow to make it use the new HAVE_*
> scheme.
>

I suggested something similar here:
http://marc.info/?l=linux-kernel&m=118670671806100&w=2

> > Or just let the subsystem always be available.
>
> It used to be always available, but then it was changed. Assuming there
> was a reason for this change, I guess we don't want to change it back.
>

Adrian had concerns about users enabling NET_DMA when the hardware
capability is relatively rare. So, +1 for HAVE_DMA_DEVICE

> Haavard

--
Dan


\
 
 \ /
  Last update: 2008-02-12 23:31    [W:0.039 / U:9.024 seconds]
©2003-2018 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site