lkml.org 
[lkml]   [2008]   [Feb]   [12]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    SubjectRe: [-mm PATCH] register_memory/unregister_memory clean ups
    From
    Date
    On Tue, 2008-02-12 at 13:57 -0800, Dave Hansen wrote:
    > On Tue, 2008-02-12 at 13:56 -0800, Badari Pulavarty wrote:
    > >
    > > +static void __remove_section(struct zone *zone, unsigned long
    > > section_nr)
    > > +{
    > > + if (!valid_section_nr(section_nr))
    > > + return;
    > > +
    > > + unregister_memory_section(__nr_to_section(section_nr));
    > > + sparse_remove_one_section(zone, section_nr);
    > > +}
    >
    > I do think passing in a mem_section* here is highly superior. It makes
    > it impossible to pass a pfn in and not get a warning.
    >

    Only problem is, I need to hold pgdat_resize_lock() if pass *ms.
    If I don't hold the resize_lock, I have to re-evaluate. And also,
    I need to pass section_nr for decoding the mem_map anyway :(

    Thanks,
    Badari



    \
     
     \ /
      Last update: 2008-02-12 23:09    [W:0.021 / U:150.160 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site