lkml.org 
[lkml]   [2008]   [Feb]   [12]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] [1/5] Only do century BCD conversion when we know the RTC is BCD
On Mon, 11 Feb 2008, Andi Kleen wrote:

> > So the warning comes a bit late :)
>
> I suspect if this was wrong before it would not have been noticed
> because user space hwclock would work around it.

And how exaclty does it work around ? By setting the binary cmos clock
with BCD values ?

> The warning certainly won't hurt.

It won't.

> Anyways if you feel strongly about this (I don't) then drop
> this patch, but apply the other ones in the series.

I'm not opposing the patch, I merily asked for a removal of the never
changing constant.

> The main one I consider important is the change to the 2000 offset
> for 32bit to extend the 32bit lifetime.

Picked the whole lot up.

Thanks,

tglx


\
 
 \ /
  Last update: 2008-02-12 21:39    [from the cache]
©2003-2011 Jasper Spaans. Advertise on this site