lkml.org 
[lkml]   [2008]   [Feb]   [12]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    Date
    From
    Subject[BUGFIX 2/2] gdth: bugfix for the Timer at exit crash

    gdth _exit would first remove all cards then stop the timer
    and would not sync with the timer function. This caused a crash
    in gdth_timer() when module was unloaded.

    del_timer_sync the timer before we delete the cards.

    NOT YET TESTED

    Signed-off-by: Boaz Harrosh <bharrosh@panasas.com>
    ---
    drivers/scsi/gdth.c | 15 ++++++++-------
    1 files changed, 8 insertions(+), 7 deletions(-)

    diff --git a/drivers/scsi/gdth.c b/drivers/scsi/gdth.c
    index 8eb78be..103280e 100644
    --- a/drivers/scsi/gdth.c
    +++ b/drivers/scsi/gdth.c
    @@ -3793,6 +3793,8 @@ static void gdth_timeout(ulong data)
    gdth_ha_str *ha;
    ulong flags;

    + BUG_ON(list_empty(&gdth_instances));
    +
    ha = list_first_entry(&gdth_instances, gdth_ha_str, list);
    spin_lock_irqsave(&ha->smp_lock, flags);

    @@ -5146,8 +5148,6 @@ static void gdth_remove_one(gdth_ha_str *ha)
    ha->sdev = NULL;
    }

    - gdth_flush(ha);
    -
    if (shp->irq)
    free_irq(shp->irq,ha);

    @@ -5245,14 +5245,15 @@ static void __exit gdth_exit(void)
    {
    gdth_ha_str *ha;

    - list_for_each_entry(ha, &gdth_instances, list)
    - gdth_remove_one(ha);
    + unregister_chrdev(major,"gdth");
    + unregister_reboot_notifier(&gdth_notifier);

    #ifdef GDTH_STATISTICS
    - del_timer(&gdth_timer);
    + del_timer_sync(&gdth_timer);
    #endif
    - unregister_chrdev(major,"gdth");
    - unregister_reboot_notifier(&gdth_notifier);
    +
    + list_for_each_entry(ha, &gdth_instances, list)
    + gdth_remove_one(ha);
    }

    module_init(gdth_init);
    --
    1.5.3.3



    \
     
     \ /
      Last update: 2008-02-12 18:45    [W:0.024 / U:89.492 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site