Messages in this thread | | | Date | Mon, 11 Feb 2008 23:08:57 +0100 (CET) | From | Thomas Gleixner <> | Subject | Re: [PATCH] [1/5] Only do century BCD conversion when we know the RTC is BCD |
| |
On Mon, 11 Feb 2008, Andi Kleen wrote: > > Nothing ever defines RTC_PORT and RTC_ALWAYS_BCD > > > > So we can get rid of that stuff completely. > > Please see the second version of the patch series. This means I didn't drop it
I'm already replying to the second version of the patch series AFAICT.
> completely, but added a warning about it not agreeing with the status > register. If this warning never triggers it can be dropped eventually, > if it triggers RTC_ALWAYS_BCD should be unset.
#define RTC_ALWAYS_BCD 1 is there since Linux 1.0 and got never changed for x86.
So the warning comes a bit late :)
Later on the #ifdef RTC_PORT was introduced to share the header in include/linux across architectures. When the header got copied to include/i386 and elsewhere this just was never removed.
Thanks,
tglx
| |