lkml.org 
[lkml]   [2008]   [Feb]   [11]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH 7/8] Do not recompute msgmni anymore if explicitely set by user
    On Mon, 11 Feb 2008 15:16:53 +0100
    Nadia.Derbey@bull.net wrote:

    > [PATCH 07/08]
    >
    > This patch makes msgmni not recomputed anymore upon ipc namespace creation /
    > removal or memory add/remove, as soon as it has been set from userland.
    >
    > As soon as msgmni is explicitely set via procfs or sysctl(), the associated
    > callback routine is unregistered from the ipc namespace notifier chain.
    >

    The patch series looks pretty good.

    > ===================================================================
    > --- linux-2.6.24-mm1.orig/ipc/ipc_sysctl.c 2008-02-08 16:07:15.000000000 +0100
    > +++ linux-2.6.24-mm1/ipc/ipc_sysctl.c 2008-02-08 16:08:32.000000000 +0100
    > @@ -35,6 +35,24 @@ static int proc_ipc_dointvec(ctl_table *
    > return proc_dointvec(&ipc_table, write, filp, buffer, lenp, ppos);
    > }
    >
    > +static int proc_ipc_callback_dointvec(ctl_table *table, int write,
    > + struct file *filp, void __user *buffer, size_t *lenp, loff_t *ppos)
    > +{
    > + size_t lenp_bef = *lenp;
    > + int rc;
    > +
    > + rc = proc_ipc_dointvec(table, write, filp, buffer, lenp, ppos);
    > +
    > + if (write && !rc && lenp_bef == *lenp)
    > + /*
    > + * Tunable has successfully been changed from userland:
    > + * disable its automatic recomputing.
    > + */
    > + unregister_ipcns_notifier(current->nsproxy->ipc_ns);
    > +
    > + return rc;
    > +}

    If you haven't done so, could you please check that it all builds cleanly
    with CONFIG_PROCFS=n, and that all code which isn't needed if procfs is
    disabled is not present in the final binary?




    \
     
     \ /
      Last update: 2008-02-11 21:37    [W:0.033 / U:61.636 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site