| | Date | Mon, 11 Feb 2008 11:32:16 -0800 (PST) | | From | Christoph Lameter <> | | Subject | Re: [patch 1/4] mempolicy: convert MPOL constants to enum |
| |
On Mon, 11 Feb 2008, David Rientjes wrote:
> The mempolicy mode constants, MPOL_DEFAULT, MPOL_PREFERRED, MPOL_BIND, > and MPOL_INTERLEAVE, are better declared as part of an enum for type > checking. > > The policy member of struct mempolicy is also converted from type short > to type unsigned short. A negative policy does not have any legitimate > meaning, so it is possible to change its type in preparation for adding > optional mode flags later.
The second paragraphs seems to indicate that such an approach does not work since we also use MPOL_xx constants to set flags in the memory policies?
|