lkml.org 
[lkml]   [2008]   [Feb]   [11]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [patch 1/4] mempolicy: convert MPOL constants to enum
On Mon, 11 Feb 2008, Andi Kleen wrote:

> > The mempolicy mode constants, MPOL_DEFAULT, MPOL_PREFERRED, MPOL_BIND,
> > and MPOL_INTERLEAVE, are better declared as part of an enum for type
> > checking.
>
> What type checking? There is none in standard C for enums.
>

"Type checking" probably isn't the best description for it. As I
mentioned in the changelog for the second patch in this series, a function
with a formal type of 'enum mempolicy_mode' indicates that the optional
mode flags have already been stripped off and the only possible values are
those of 'enum mempolicy_mode'. The implementation will not need to use
mpol_mode() in conditionals or switch statements. I think it's a clean
way of describing what is acting on modes and what is acting on flags.

Functions with a formal type of an 'int' contain both the mode and flags.

David


\
 
 \ /
  Last update: 2008-02-11 20:29    [W:0.243 / U:0.124 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site