lkml.org 
[lkml]   [2008]   [Feb]   [11]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRe: [PATCH] Prevent IDE boot ops on NUMA system in mainline
Date
On Monday 11 February 2008, Andi Kleen wrote:
>
> Without this patch a Opteron test system here oopses at boot with currentg git.
>
> Calling to_pci_dev() on a NULL pointer gives a negative value so the following NULL
> pointer check never triggers and then an illegal address is referenced. Check the
> unadjusted original device pointer for NULL instead.
>
> Signed-off-by: Andi Kleen <ak@suse.de>

Thanks Andi!

This may explain+resolve ide_generic OOPS-es reported by Pavel/Kamalesh/Nish.

[ I also see that Linus has already merged the patch and you've followed
up on pcibus_to_node() issue so there is nothing left for me to do...

I really love when things turn out like this... ;) ]

> Index: linux/include/linux/ide.h
> ===================================================================
> --- linux.orig/include/linux/ide.h
> +++ linux/include/linux/ide.h
> @@ -1294,7 +1294,7 @@ static inline void ide_dump_identify(u8
> static inline int hwif_to_node(ide_hwif_t *hwif)
> {
> struct pci_dev *dev = to_pci_dev(hwif->dev);
> - return dev ? pcibus_to_node(dev->bus) : -1;
> + return hwif->dev ? pcibus_to_node(dev->bus) : -1;
> }
>
> static inline ide_drive_t *ide_get_paired_drive(ide_drive_t *drive)


\
 
 \ /
  Last update: 2008-02-11 20:25    [W:0.188 / U:0.484 seconds]
©2003-2014 Jasper Spaans. Advertise on this site