Messages in this thread | | | Date | Mon, 11 Feb 2008 11:03:38 -0500 | From | Mark Lord <> | Subject | Re: kgdb in git-x86#mm review |
| |
Andi Kleen wrote: > .. > You should probably use simple_strtoul() instead of inventing an > own hex parser in kgdb.c. And sprintf instead of an own hex writer. > In general more use sprintf would probably shorten a lot of the parser > code. ..
Speaking of which.. the kernel implementation of snprintf() seems to have a bug somewhere, in that it returns an incorrect count in some situations -- mostly around where the buffer is too small to hold the data being written. There's an off-by-one bug there somewhere, but I have not had time yet to track it down more precisely.
Cheers
| |