Messages in this thread |  | | | Date | Sun, 10 Feb 2008 21:27:41 -0800 | | From | Yinghai Lu <> | | Subject | Re: [PATCH] scsi: ses fix mem leaking when fail to add intf | |
On Sunday 10 February 2008 08:28:38 pm James Bottomley wrote:
>
> On Sat, 2008-02-09 at 15:15 -0800, Yinghai Lu wrote:
> > [PATCH] scsi: ses fix mem leaking when fail to add intf
> >
> > fix leaking with scomp leaking when failing.
> > also remove one extra space.
>
> There are still a few extraneous code moves in this one. This is about
> the correct minimal set, isn't it?
if buf allocation for page 7 get NULL...
if put
+ if (!buf)
+ goto err_free;
still not right, because still undo
edev = enclosure_register(cdev->dev, sdev->sdev_gendev.bus_id,
components, &ses_enclosure_callbacks);
all just add
+ if (!buf)
+ goto simple_populate;
there?
YH
|  |