Messages in this thread |  | | | From | Chris Mason <> | | Subject | Re: [ANNOUNCE] Btrfs v0.12 released | | Date | Mon, 11 Feb 2008 08:42:20 -0500 | |
On Sunday 10 February 2008, David Miller wrote:
> From: Chris Mason <chris.mason@oracle.com>
> Date: Wed, 6 Feb 2008 12:00:13 -0500
>
> This function never returns an error, so the simplest fix was to
> return the hash value which avoids all of the issues. In attempting
> other schemes to fix this, I found it very difficult to give gcc
> a packed attribute for that "u64 *" argument other than to create
> some new pseudo structure which would have been ugly.
>
Many thanks, I clearly didn't put enough thought into the unaligned access
problems.
> Similar code lives in the btrfs kernel code too, I'll try to get a
> partition at least mounted and working minimally and if successful
> I'll send you patches for that too.
The kernel is actually worse, because the set/get macros are more complex.
Some live in ctree.h like in the progs, but the nasty ones live in
struct-funcs.c
-chris
|  |