lkml.org 
[lkml]   [2008]   [Feb]   [11]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
Patch in this message
/
From
Subject[PATCH] [1/1] CPA: Flush the caches when setting pages not present v2
Date

The AMD64 pci-gart code sets pages not present to prevent
cache coherency problems. When doing this it is safer to flush the
caches too so that there are no cache lines left over from when
the pages were still mapped.

So consider clearing of the present bit as a cache flush indicator.

Note that debug pagealloc marks pages regularly not present either, but it won't
call this because it calls directly into a lower level function.

I have not actually seen failures from this, but it seems safer
to do it this way.

v2: Force WBINVD in this case because CLFLUSH does not work for !P pages.
Improve description slightly.

Signed-off-by: Andi Kleen <ak@suse.de>

---
arch/x86/mm/pageattr.c | 13 ++++++++++---
1 file changed, 10 insertions(+), 3 deletions(-)
Index: linux/arch/x86/mm/pageattr.c
===================================================================
--- linux.orig/arch/x86/mm/pageattr.c
+++ linux/arch/x86/mm/pageattr.c
@@ -122,6 +122,14 @@ static void cpa_flush_range(unsigned lon
*/
if (pte && (pte_val(*pte) & _PAGE_PRESENT))
clflush_cache_range((void *) addr, PAGE_SIZE);
+ else {
+ /*
+ * Make sure there are no left overs of pages
+ * set non present in the cache.
+ */
+ cpa_flush_all(cache);
+ return;
+ }
}
}

@@ -670,9 +678,16 @@ static int __change_page_attr_set_clr(st
return 0;
}

-static inline int cache_attr(pgprot_t attr)
+static inline int cache_attr(pgprot_t set, pgprot_t clr)
{
- return pgprot_val(attr) &
+ /*
+ * Clearing pages is usually done for cache cohereny reasons
+ * (except for pagealloc debug, but that doesn't call this anyways)
+ * It's safer to flush the caches in this case too.
+ */
+ if (pgprot_val(clr) & _PAGE_PRESENT)
+ return 1;
+ return pgprot_val(set) &
(_PAGE_PAT | _PAGE_PAT_LARGE | _PAGE_PWT | _PAGE_PCD);
}

@@ -709,7 +724,7 @@ static int change_page_attr_set_clr(unsi
* No need to flush, when we did not set any of the caching
* attributes:
*/
- cache = cache_attr(mask_set);
+ cache = cache_attr(mask_set, mask_clr);

/*
* On success we use clflush, when the CPU supports it to

\
 
 \ /
  Last update: 2008-02-11 14:19    [from the cache]
©2003-2011 Jasper Spaans