Messages in this thread |  | | | Date | Sat, 9 Feb 2008 23:21:16 -0800 | | From | Greg KH <> | | Subject | Re: [PATCH] Change pci_raw_ops to pci_raw_read/write | |
On Sat, Feb 09, 2008 at 10:25:23PM -0800, Yinghai Lu wrote:
> On Feb 9, 2008 4:41 AM, Matthew Wilcox <matthew@wil.cx> wrote:
> > On Thu, Feb 07, 2008 at 10:54:05AM -0500, Tony Camuso wrote:
> > > Matthew,
> > >
> > > Perhaps I missed it, but did you address Yinghai's concerns?
> >
> > No, I was on holiday.
> >
> > > Yinghai Lu wrote:
> > > >On Jan 28, 2008 7:03 PM, Matthew Wilcox <matthew@wil.cx> wrote:
> > > >>
> > > >>-int pci_conf1_write(unsigned int seg, unsigned int bus,
> > > >>+static int pci_conf1_write(unsigned int seg, unsigned int bus,
> > > >> unsigned int devfn, int reg, int len, u32
> > > >> value)
> > > >
> > > >any reason to change pci_conf1_read/write to static?
> >
> > Yes -- it no longer needs to be called from outside this file.
> >
> > > >>+config ATA_RAM
> > > >>+ tristate "ATA RAM driver"
> > > >>+
> > > >
> > > >related?
> >
>
> looks good. it should get into -mm or x86/mm for some testing
Can I get a revised version of this, without the incorrect hunk?
thanks,
greg k-h
|  |