lkml.org 
[lkml]   [2008]   [Feb]   [10]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [3/6] kgdb: core
    On Sun, Feb 10, 2008 at 02:19:06PM +0100, Jesper Juhl wrote:
    > On 10/02/2008, Marcin Slusarz <marcin.slusarz@gmail.com> wrote:
    > > On Sun, Feb 10, 2008 at 08:13:31AM +0100, Ingo Molnar wrote:
    > ...
    > > > +
    > > > + if (CACHE_FLUSH_IS_SAFE) {
    > > > + if (current->mm && addr < TASK_SIZE) {
    > > > + flush_cache_range(current->mm->mmap_cache,
    > > > + addr, addr + BREAK_INSTR_SIZE);
    > > > + } else {
    > > > + flush_icache_range(addr, addr +
    > > > + BREAK_INSTR_SIZE);
    > > > + }
    > > > + }
    > > unneeded braces (here and in many other places)
    > >
    >
    > While they are not strictly needed, I for one would argue they should
    > probably stay.
    >
    > if (foo)
    > bar();
    >
    > is not always safe in case bar() is a macro.
    then fix this broken macro and leave calling code alone

    > is always safe and is more robust when the code gets changed later
    > since you don't accidentally end up with someone mistakenly turning it
    > into
    >
    > if (foo)
    > bar();
    > baz();
    following coding style and reading code before submission will
    catch this kind of bugs

    Marcin


    \
     
     \ /
      Last update: 2008-02-10 15:03    [from the cache]
    ©2003-2014 Jasper Spaans. hosted at Digital Ocean