lkml.org 
[lkml]   [2008]   [Feb]   [10]   [last100]   RSS Feed
Views: [more markup]  [less markup]  [headers]  [forward] 
 
Messages in this thread
/
DateSat, 9 Feb 2008 22:25:23 -0800
From"Yinghai Lu" <>
SubjectRe: [PATCH] Change pci_raw_ops to pci_raw_read/write
On Feb 9, 2008 4:41 AM, Matthew Wilcox <matthew@wil.cx> wrote:
> On Thu, Feb 07, 2008 at 10:54:05AM -0500, Tony Camuso wrote:
> > Matthew,> >> > Perhaps I missed it, but did you address Yinghai's concerns?>> No, I was on holiday.>> > Yinghai Lu wrote:> > >On Jan 28, 2008 7:03 PM, Matthew Wilcox <matthew@wil.cx> wrote:
> > >>> > >>-int pci_conf1_write(unsigned int seg, unsigned int bus,
> > >>+static int pci_conf1_write(unsigned int seg, unsigned int bus,
> > >>                           unsigned int devfn, int reg, int len, u32
> > >>                           value)
> > >
> > >any reason to change pci_conf1_read/write to static?>> Yes -- it no longer needs to be called from outside this file.
>> > >>+config ATA_RAM> > >>+       tristate "ATA RAM driver"> > >>+> > >> > >related?>

looks good. it should get into -mm or x86/mm for some testing

YH


\
 
 \ /
  Last update: 2008-02-10 07:27    [from the cache]
©2003-2008