lkml.org 
[lkml]   [2008]   [Feb]   [1]   [last100]   RSS Feed
Views: [more markup]  [less markup]  [headers]  [forward] 
 
Messages in this thread
/
DateFri, 1 Feb 2008 11:56:24 +0100
FromIngo Molnar <>
SubjectRe: [PATCH] x86: sparse errors from string_32.h
* Harvey Harrison <harvey.harrison@gmail.com> wrote:

>  		case 1:
> -			*(unsigned char *)s = pattern;
> +			*(unsigned char *)s = pattern & 0xff;

i've applied your fix - but wouldnt it be cleaner to just cast the 
pattern variable to unsigned char instead?

	Ingo


\
 
 \ /
  Last update: 2008-02-01 10:59    [from the cache]
©2003-2008