Messages in this thread | | | Date | Mon, 8 Dec 2008 16:50:18 +0100 | From | Ingo Molnar <> | Subject | Re: [PATCH 1/3] tracing/function-graph-tracer: introduce __notrace_funcgraph to filter special functions |
| |
* Frédéric Weisbecker <fweisbec@gmail.com> wrote:
> 2008/12/8 Ingo Molnar <mingo@elte.hu>: > > > > * Frederic Weisbecker <fweisbec@gmail.com> wrote: > > > >> Impact: trace more functions > >> > >> When the function graph tracer is configured, three more files are not > >> traced to prevent only four functions to be traced. And this impacts > >> the normal function tracer too. > >> > >> arch/x86/kernel/process_64/32.c: > >> > >> I had crashes when I let this file traced. After some debugging, I saw > >> that the "current" task point was changed inside__swtich_to(), ie: > >> "write_pda(pcurrent, next_p);" inside process_64.c Since the tracer > >> store the original return address of the function inside current, we > >> had crashes. Only __switch_to() has to be traced. > >> > >> kernel/module.c and kernel/extable.c: > >> > >> Because of a function used internally by the function graph tracer: > >> __kernel_text_address() > >> > >> To let the other functions inside these files to be traced, this patch > >> introduces the __notrace_funcgraph function prefix which is __notrace > >> if function graph tracer is configured and nothing if not. > >> > >> Signed-off-by: Frederic Weisbecker <fweisbec@gmail.com> > > > > applied to tip/tracing/function-graph-tracer, thanks Frederic! > > Thanks! > > > [ one small request: would it be possible to include the diffstat in the > > patches you send? If you use git-diff then it's the --patch-with-stat > > option. ] > > > Ok. BTW. I wanted to give a try on linux-next to test the last ftrace > stuffs, but the auto-ftrace-next branch seems too much old. Are the > auto branches updated every week or something like this...?
yes - but there's a few pending regressions right now delaying the reintegration.
Ingo -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |