Messages in this thread | | | From | Thomas Renninger <> | Subject | Re: [PATCH] PCIe ASPM causes machine (HP Compaq 6735s) to sometimes freeze hard at boot at PCI initialization time | Date | Mon, 8 Dec 2008 15:56:57 +0100 |
| |
On Monday 08 December 2008 02:32:42 Shaohua Li wrote: > On Sat, 2008-12-06 at 02:21 +0800, Matthew Garrett wrote: > > On Fri, Dec 05, 2008 at 02:07:13PM +0100, Thomas Renninger wrote: > > > PCIE: Break out of endless loop waiting for PCI config bits to switch > > > > > > Makes a Compaq 6735s boot reliably again which hang in the loop > > > on some boots. > > > > Which device does it get stuck on? > > > > > + if (loop_count == 100) > > > + dev_printk (KERN_WARNING, &pdev->dev, "Could not configure ASPM\n"); > > > > "ASPM: Could not configure common clock\n"? ASPM should still work, > > though with higher latency. It probably also needs to revert the > > configuration changes. > > Yep, Just undo the pci config writes of pcie_aspm_configure_common_clock > should be fine to me. Maybe an expiration time is ok here. > Does the device work after this?
After not writing back the pci values as done with this patch? Yes, I think it did.
It definitely does with this patch.
What about this one:
| |