lkml.org 
[lkml]   [2008]   [Dec]   [8]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 1/3] tracing/function-graph-tracer: introduce __notrace_funcgraph to filter special functions

* Frederic Weisbecker <fweisbec@gmail.com> wrote:

> Impact: trace more functions
>
> When the function graph tracer is configured, three more files are not
> traced to prevent only four functions to be traced. And this impacts
> the normal function tracer too.
>
> arch/x86/kernel/process_64/32.c:
>
> I had crashes when I let this file traced. After some debugging, I saw
> that the "current" task point was changed inside__swtich_to(), ie:
> "write_pda(pcurrent, next_p);" inside process_64.c Since the tracer
> store the original return address of the function inside current, we
> had crashes. Only __switch_to() has to be traced.
>
> kernel/module.c and kernel/extable.c:
>
> Because of a function used internally by the function graph tracer:
> __kernel_text_address()
>
> To let the other functions inside these files to be traced, this patch
> introduces the __notrace_funcgraph function prefix which is __notrace
> if function graph tracer is configured and nothing if not.
>
> Signed-off-by: Frederic Weisbecker <fweisbec@gmail.com>

applied to tip/tracing/function-graph-tracer, thanks Frederic!

[ one small request: would it be possible to include the diffstat in the
patches you send? If you use git-diff then it's the --patch-with-stat
option. ]

Ingo


\
 
 \ /
  Last update: 2008-12-08 15:17    [W:0.092 / U:0.676 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site