lkml.org 
[lkml]   [2008]   [Dec]   [8]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRe: [PATCH 1/1] fs: fix warning message with inserting a single space
Date
Am Montag, 8. Dezember 2008 14:16:05 schrieb Artem Bityutskiy:
> Nick Andrew wrote:
> > On Mon, Dec 08, 2008 at 01:54:12PM +0200, Hiroshi DOYU wrote:
> >> - printk(KERN_WARNING "%s: %s passed in a files array"
> >> + printk(KERN_WARNING "%s: %s passed in a files array "
> >> "with an index of 1!\n", __func__,
> >> s->s_type->name);
> >
> > Yep. These look like the same kind of thing:
> >
> > arch/powerpc/platforms/cell/iommu.c +1109
> > pr_debug("iommu: hash window doesn't fit in"
> > "real DMA window\n");
>
> Do we have such kind of check in checkpatch.pl? Would be useful.

No, it wouldn't. A kernel message should be grepable. So, when in doubt,
screw the screen width limit. Don't make making ungreppable messages
easier.

Regards
Oliver


\
 
 \ /
  Last update: 2008-12-08 14:25    [from the cache]
©2003-2011 Jasper Spaans. Advertise on this site