Messages in this thread | | | Date | Sun, 7 Dec 2008 16:43:33 +1100 | From | Stephen Rothwell <> | Subject | Re: [PATCH linux-next] powerpc/powermac: Add missing of_node_put |
| |
Hi Paul,
On Sun, 7 Dec 2008 13:31:00 +1100 Paul Mackerras <paulus@samba.org> wrote: > > I'm really in two minds about applying any of the of_node_put patches > that only affect powermacs. The reference counts only matter on > platforms where we update the OF device tree at runtime, which is > currently only IBM pSeries machines. Since we don't have any hotplug > on powermacs, and never will have, the OF device tree is completely > static and we don't actually need refcounts on the nodes at all, so > who cares if they're a bit higher than they might be? > > In particular, the VIA whose node we're looking for here is built-in > on the motherboard, and there can never be more than one, and it can > never be removed.
I my mind it is about consistent use of the API and good examples for people to copy. Also, in about a year you will be presented with the same set of patches when a new pair of eyes looks at the same code and notices the discrepancy ...
-- Cheers, Stephen Rothwell sfr@canb.auug.org.au http://www.canb.auug.org.au/~sfr/ [unhandled content-type:application/pgp-signature] | |