Messages in this thread | | | Date | Sun, 7 Dec 2008 20:32:44 -0800 | From | Andrew Morton <> | Subject | Re: [PATCH, take2] percpu_counter: FBC_BATCH might be too big |
| |
On Sun, 07 Dec 2008 19:30:10 +0100 Eric Dumazet <dada1@cosmosbay.com> wrote:
> > > > Do > > > > $EDITOR $(grep -l hotcpu_notifier */*.c) > > > > and you'll see lots of code gets it right, and lots of code gets it wrong. > > I see nothing interesting, I must be blind. > > lib/percpu_counter.c: In function 'percpu_counter_startup': > lib/percpu_counter.c:158: error: 'percpu_counter_hotcpu_callback' undeclared (first use in this function) > lib/percpu_counter.c:158: error: (Each undeclared identifier is reported only once > lib/percpu_counter.c:158: error: for each function it appears in.) > make[1]: *** [lib/percpu_counter.o] Error 1
Perhaps you still had percpu_counter_hotcpu_callback inside #ifdef.
That a look at kernel/workqueue.c, fs/buffer.c. No #ifdef CONFIG_HOTPLUG_CPU needed at all.
| |