lkml.org 
[lkml]   [2008]   [Dec]   [7]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 03/13] checkpatch: Add warning for p0-patches
    Date
    From: Wolfram Sang <w.sang@pengutronix.de>

    Some people work internally with -p0-patches which has the danger that
    one forgets to convert them to -p1 before mainlining. Bitten myself and
    seen p0-patches in mailing lists occasionally, this patch adds a warning
    to checkpatch.pl in case a patch is -p0. If you really want, you can
    fool this check to generate false positives, this is why it just spits a
    warning. Making the check 100% proof is trickier than it looks, so let's
    start with a version which catches the cases of real use.

    [apw@canonical.com: update message language, handle null prefix, add tests]
    Signed-off-by: Wolfram Sang <w.sang@pengutronix.de>
    Signed-off-by: Andy Whitcroft <apw@canonical.com>
    ---
    scripts/checkpatch.pl | 8 +++++++-
    1 files changed, 7 insertions(+), 1 deletions(-)

    diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl
    index f015698..b953c76 100755
    --- a/scripts/checkpatch.pl
    +++ b/scripts/checkpatch.pl
    @@ -1057,6 +1057,7 @@ sub process {
    my $in_comment = 0;
    my $comment_edge = 0;
    my $first_line = 0;
    + my $p1_prefix = '';

    my $prev_values = 'E';

    @@ -1205,7 +1206,12 @@ sub process {
    # extract the filename as it passes
    if ($line=~/^\+\+\+\s+(\S+)/) {
    $realfile = $1;
    - $realfile =~ s@^[^/]*/@@;
    + $realfile =~ s@^([^/]*)/@@;
    +
    + $p1_prefix = $1;
    + if ($tree && $p1_prefix ne '' && -e "$root/$p1_prefix") {
    + WARN("patch prefix '$p1_prefix' exists, appears to be a -p0 patch\n");
    + }

    if ($realfile =~ m@^include/asm/@) {
    ERROR("do not modify files in include/asm, change architecture specific files in include/asm-<architecture>\n" . "$here$rawline\n");
    --
    1.6.0.4.911.gc990


    \
     
     \ /
      Last update: 2008-12-07 19:35    [W:0.021 / U:29.992 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site