Messages in this thread | | | From | "Rafael J. Wysocki" <> | Subject | Re: [PATCH] kernel/freezer.c : Removing extra checking. | Date | Sat, 6 Dec 2008 14:41:15 +0100 |
| |
On Saturday, 6 of December 2008, Rakib Mullick wrote: > Impact: Reduces an extra checking. > > Following patch removes an extra checking. We can remove it since, the > current task is frozen. If the current task is not frozen, then it > will return from __else__ condition of freezing(current) check. So, > the check becames unnecessary. It also reduces 32 bytes of text space > on my x86 (32 bit) system.
What will happen with this patch applied when a task is woken up for some reason other than thawing?
> Signed-off-by: Rakib Mullick <rakib.mullick@gmail.com> > > --- linux-2.6-orig/kernel/freezer.c 2008-12-05 19:53:45.000000000 +0600 > +++ linux-2.6/kernel/freezer.c 2008-12-05 19:55:40.000000000 +0600 > @@ -46,8 +46,6 @@ void refrigerator(void) > > for (;;) { > set_current_state(TASK_UNINTERRUPTIBLE); > - if (!frozen(current)) > - break; > schedule(); > } > pr_debug("%s left refrigerator\n", current->comm); > --
| |