lkml.org 
[lkml]   [2008]   [Dec]   [5]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [patch] export percpu cpuacct cgroup stats
Ken Chen wrote:
> On Thu, Dec 4, 2008 at 11:54 PM, Li Zefan <lizf@cn.fujitsu.com> wrote:
>>> + seq_printf(m, "%llu ", percpu);
>> Should be:
>> + seq_printf(m, "%llu ", (unsigned long long)percpu);
>>
>> Otherwsise:
>> kernel/sched.c: In function 'cpuacct_percpu_seq_read':
>> kernel/sched.c:9359: warning: format '%llu' expects type 'long long unsigned int',
>> but argument 3 has type 'u64'
>
> huh, I was just wondering about the type case in cgroup_read_u64()
> when I was looking at it earlier. That explains it. Diff patch
> attached.
>

Reviewed-by: Li Zefan <lizf@cn.fujitsu.com>

> diff --git a/kernel/sched.c b/kernel/sched.c
> index e32c094..055c54f 100644
> --- a/kernel/sched.c
> +++ b/kernel/sched.c
> @@ -9356,7 +9356,7 @@ static int cpuacct_percpu_seq_read
> spin_lock_irq(&cpu_rq(i)->lock);
> percpu = *percpu_ptr(ca->cpuusage, i);
> spin_unlock_irq(&cpu_rq(i)->lock);
> - seq_printf(m, "%llu ", percpu);
> + seq_printf(m, "%llu ", (unsigned long long) percpu);
> }
> seq_printf(m, "\n");
> return 0;
>
>



\
 
 \ /
  Last update: 2008-12-05 09:39    [W:0.099 / U:0.940 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site